Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting misspelled words #1349

Merged
merged 3 commits into from May 10, 2021
Merged

Correcting misspelled words #1349

merged 3 commits into from May 10, 2021

Conversation

@moritamori
Copy link
Contributor

@moritamori moritamori commented Feb 13, 2021

No description provided.

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Feb 13, 2021

CLA assistant check
All committers have signed the CLA.

@moritamori moritamori changed the title Correcting Misspelled Words Correcting misspelled words Feb 13, 2021
Copy link
Contributor

@marckhouzam marckhouzam left a comment

Thanks for this.

@@ -302,7 +302,7 @@ func (c *Command) getCompletions(args []string) (*Command, []string, ShellCompDi
if len(finalArgs) == 0 && !foundLocalNonPersistentFlag {
// We only complete sub-commands if:
// - there are no arguments on the command-line and
// - there are no local, non-peristent flag on the command-line or TraverseChildren is true
// - there are no local, non-persistent flag on the command-line or TraverseChildren is true
Copy link
Contributor

@marckhouzam marckhouzam Feb 13, 2021

Might as well put an 's' at 'flag' since we're correcting this sentence

Copy link
Collaborator

@jpmcb jpmcb left a comment

Hi @moritamori - can you rebase and get the latest changes I just merged from #1192 (which include a file name change)

Also, if you could include the changes suggested in #1350, that would be highly appreciated!

@jpmcb jpmcb added the kind/bug label Feb 15, 2021
@moritamori
Copy link
Contributor Author

@moritamori moritamori commented Feb 16, 2021

@jpmcb
Thank you for your feedback.
I rebased this branch and inclueded the changes suggested in #1350.

@moritamori
Copy link
Contributor Author

@moritamori moritamori commented Mar 8, 2021

@jpmcb
Could you accept?

@github-actions
Copy link

@github-actions github-actions bot commented May 8, 2021

This PR is being marked as stale due to a long period of inactivity

jpmcb
jpmcb approved these changes May 10, 2021
Copy link
Collaborator

@jpmcb jpmcb left a comment

LGTM - thanks for the patience on this!! 🚀

@jpmcb jpmcb merged commit 4590150 into spf13:master May 10, 2021
8 checks passed
@jpmcb jpmcb mentioned this pull request May 10, 2021
@renovate renovate bot mentioned this pull request Jul 1, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants