Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test golang 1.16.x and 1.17.x too #1425

Merged
merged 5 commits into from Aug 26, 2021
Merged

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Jun 29, 2021

Golang 1.16 was released in February 2021. This PR adds it to CI.

/cc @jpmcb

@github-actions github-actions bot added the admin For general admin tasks to be done usualy by maintainers label Jun 29, 2021
@umarcor umarcor mentioned this pull request Jun 29, 2021
@umarcor umarcor force-pushed the ci-bump branch 4 times, most recently from 1ce8e9a to bc7fe52 Compare Jul 1, 2021
@umarcor
Copy link
Contributor Author

umarcor commented Jul 21, 2021

In August, Golang 1.17 will be released. @jpmcb @jharshman can we please have this merged before?

@umarcor
Copy link
Contributor Author

umarcor commented Aug 4, 2021

ping @jpmcb

https://github.com/spf13/cobra/blob/master/CONDUCT.md#ci-testing

CI Testing

Maintainers will ensure the Cobra test suite utilizes the current supported versions of Golang.

@umarcor umarcor force-pushed the ci-bump branch 2 times, most recently from f067afc to cdf6669 Compare Aug 17, 2021
@umarcor umarcor changed the title ci: test golang 1.16.x too ci: test golang 1.16.x and 1.17.x too Aug 17, 2021
@umarcor
Copy link
Contributor Author

umarcor commented Aug 17, 2021

Since Go 1.17 was released yesterday (https://endoflife.date/go), this PR adds 1.17 to the test matrix.

@jharshman jharshman merged commit 4fd30b6 into spf13:master Aug 26, 2021
11 checks passed
@umarcor umarcor deleted the ci-bump branch Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin For general admin tasks to be done usualy by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants