Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: cpuguy83/go-md2man/v2 v2.0.1 #1460

Merged
merged 1 commit into from Aug 5, 2021
Merged

Conversation

thaJeztah
Copy link
Contributor

@thaJeztah thaJeztah commented Jul 21, 2021

full diff: cpuguy83/go-md2man@v2.0.0...v2.0.1

  • Fix handling multiple definition descriptions
  • Fix inline markup causing table cells to split
  • Remove escaping tilde character (prevents tildes (~) from disappearing).
  • Do not escape dash, underscore, and ampersand (prevents ampersands (&) from disappearing).
  • Ignore unknown HTML tags to prevent noisy warnings

@thaJeztah
Copy link
Contributor Author

thaJeztah commented Jul 21, 2021

Ah, looks like some tests need updating because of some of the fixes

=== RUN   TestGenManSeeAlso
    man_docs_test.go:135: Second line after SEE ALSO wasn't correct: got \fBroot-bbb(1)\fP, \fBroot-ccc(1)\fP, not \fBroot\-bbb(1)\fP, \fBroot\-ccc(1)\fP
--- FAIL: TestGenManSeeAlso (0.00s)

@thaJeztah thaJeztah marked this pull request as draft Jul 21, 2021
full diff: cpuguy83/go-md2man@v2.0.0...v2.0.1

- Fix handling multiple definition descriptions
- Fix inline markup causing table cells to split
- Remove escaping tilde character (prevents tildes (`~`) from disappearing).
- Do not escape dash, underscore, and ampersand (prevents ampersands (`&`) from disappearing).
- Ignore unknown HTML tags to prevent noisy warnings

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@github-actions github-actions bot added the area/docs-generation Generation of docs via Cobra label Jul 21, 2021
@thaJeztah thaJeztah marked this pull request as ready for review Jul 21, 2021
@thaJeztah
Copy link
Contributor Author

thaJeztah commented Jul 21, 2021

@eparis @estesp @cpuguy83 ptal

estesp
estesp approved these changes Jul 21, 2021
Copy link

@estesp estesp left a comment

LGTM

Copy link

@cpuguy83 cpuguy83 left a comment

LGTM

jpmcb
jpmcb approved these changes Aug 5, 2021
Copy link
Collaborator

@jpmcb jpmcb left a comment

Thanks for this! LGTM

@jpmcb jpmcb merged commit 2a52778 into spf13:master Aug 5, 2021
7 checks passed
@thaJeztah thaJeztah deleted the update_md2man branch Aug 5, 2021
@thaJeztah
Copy link
Contributor Author

thaJeztah commented Aug 5, 2021

Thanks for review/merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs-generation Generation of docs via Cobra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants