Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: includes os package import in root command generation #1557

Merged
merged 1 commit into from Dec 9, 2021

Conversation

jpmcb
Copy link
Collaborator

@jpmcb jpmcb commented Dec 9, 2021

There was a missing os import in the root command generation after 1beb476 was merged. This prevented the default boilerplate from being buildable

Closes: #1556

Signed-off-by: John McBride <jmcbride@vmware.com>
@github-actions github-actions bot added the area/cli [deprecated] For the cobra CLI !!! moved to spf13/cobra-cli label Dec 9, 2021
@jpmcb jpmcb mentioned this pull request Dec 9, 2021
@marckhouzam
Copy link
Collaborator

marckhouzam commented Dec 9, 2021

Actually hold on, I'm trying to reproduce and I'm having problems. Give me a few minutes

@marckhouzam
Copy link
Collaborator

marckhouzam commented Dec 9, 2021

Looks good @jpmcb thanks for fixing. I was able to reproduce the problem on the master branch and show that it doesn't happen with this PR.

@jpmcb
Copy link
Collaborator Author

jpmcb commented Dec 9, 2021

Yeah - it was a really tricky one to reproduce and is buried pretty deep in the generation stuff. Thanks for the review!!

@jpmcb jpmcb merged commit 19c9c74 into spf13:master Dec 9, 2021
12 checks passed
@jpmcb jpmcb deleted the bug/missing-os-import branch Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli [deprecated] For the cobra CLI !!! moved to spf13/cobra-cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if Viper is not set, go get fails
2 participants