Fix minor annoyance of missing '--version' flag from some Help output #1707
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The Cobra project currently lacks enough contributors to adequately respond to all PRs. This bot triages issues and PRs according to the following rules:
On Sun, Sep 18, 2022, 7:40 PM Marc Khouzam ***@***.***> wrote: ***@***.**** requested changes on this pull request. This is great @fnickels <https://github.com/fnickels> ! Thanks for fixing this. Everything looks good except one nit. ------------------------------ In .gitignore <#1707 (comment)>: > @@ -37,3 +37,5 @@ bin .idea/ *.iml + +.vscode I guess this makes sense, but: 1. it shouldn't be in this PR 2. it is recommended to use your own global gitignore for those things My guess is that you didn't realize it sneaked in here. Could you remove it? — Reply to this email directly, view it on GitHub <#1707 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB7UQXCH3M4KU6U6W3MZQQDV67HBJANCNFSM5WXXNOHQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>
Yeah, That's what I used. I sort of knew this existed but have always been too lazy to look it up and configure it. Should the `.idea/` reference also be removed from `.gitignore`? francis… *Francis J. Nickels III* Riot Games ***@***.*** | C: +1.310.598.8267 Summoner Name: target1…
On Mon, Sep 19, 2022 at 10:27 AM Marc Khouzam ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In .gitignore <#1707 (comment)>: > @@ -37,3 +37,5 @@ bin .idea/ *.iml + +.vscode If it helps: git config --global core.excludesfile ~/.gitignore — Reply to this email directly, view it on GitHub <#1707 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB7UQXD7O7S5PIDLZHOQHFTV7CO63ANCNFSM5WXXNOHQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>
jimschubert added a commit to jimschubert/cobra that referenced this pull request
Oct 3, 2022
* main: (39 commits) Add '--version' flag to Help output (spf13#1707) Expose ValidateRequiredFlags and ValidateFlagGroups (spf13#1760) Document option to hide the default completion cmd (spf13#1779) ci: add workflow_dispatch (spf13#1387) add missing license headers (spf13#1809) ci: use action/setup-go's cache (spf13#1783) Adjustments to documentation (spf13#1656) Rename Powershell completion tests (spf13#1803) Support for case-insensitive command names (spf13#1802) Deprecate ExactValidArgs() and test combinations of args validators (spf13#1643) Use correct stale action `exempt-` yaml keys (spf13#1800) With go 1.18, we must use go install for a binary (spf13#1726) Clarify SetContext documentation (spf13#1748) ci: test on Golang 1.19 (spf13#1782) fix: show flags that shadow parent persistent flag in child help (spf13#1776) Update gopkg.in/yaml.v2 to gopkg.in/yaml.v3 (spf13#1766) fix(bash-v2): activeHelp length check syntax (spf13#1762) fix: correct command path in see_also for YAML doc (spf13#1771) build(deps): bump github.com/inconshreveable/mousetrap (spf13#1774) docs: add zitadel to the list (spf13#1772) ...
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.