Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With go 1.18, we must use go install for a binary #1726

Merged
merged 1 commit into from Aug 30, 2022

Conversation

marckhouzam
Copy link
Collaborator

When using go 1.18, the format "go install github.com/kyoh86/richgo@latest" is needed (go get no longer works).

This PR simply updates the warning printed by the Makefile to use "go install" instead of "go get".

Note that "go install github.com/kyoh86/richgo@latest" works with go 1.16 and higher but does not work with go 1.15. However, since installing "richgo" is only required for people who want to run the go tests for the Cobra project itself, I feel it is ok to focus on go 1.16 or higher in this case.

@umarcor you setup richgo, what do you say?

The format "go install github.com/kyoh86/richgo@latest" will work with
go 1.16 and higher.  It will not work with go 1.15.  However, since
installing "richgo" is only required for people who want to run the go
tests for the Cobra project itself, I feel it is ok to require go 1.16
or higher in this case.

Signed-off-by: Marc Khouzam <marc.khouzam@gmail.com>
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines label Jun 13, 2022
@marckhouzam marckhouzam added area/go General Go things, like go.mod or go.sum kind/testing CI/CD, testing, etc. for cobra and removed size/XS Denotes a PR that changes 0-9 lines labels Jun 13, 2022
Copy link
Contributor

@umarcor umarcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@umarcor
Copy link
Contributor

umarcor commented Aug 21, 2022

@marckhouzam please milestone this so we don't foget merging it before the next release!

@marckhouzam marckhouzam added this to the 1.6.0 milestone Aug 21, 2022
@marckhouzam
Copy link
Collaborator Author

@jpmcb I need another maintainer to approve to be able to merge this 😄

jpmcb
jpmcb approved these changes Aug 30, 2022
@jpmcb jpmcb merged commit 0580724 into spf13:main Aug 30, 2022
15 checks passed
@marckhouzam marckhouzam deleted the fix/go18 branch August 30, 2022 15:55
jimschubert added a commit to jimschubert/cobra that referenced this pull request Oct 3, 2022
* main: (39 commits)
  Add '--version' flag to Help output (spf13#1707)
  Expose ValidateRequiredFlags and ValidateFlagGroups (spf13#1760)
  Document option to hide the default completion cmd (spf13#1779)
  ci: add workflow_dispatch (spf13#1387)
  add missing license headers (spf13#1809)
  ci: use action/setup-go's cache (spf13#1783)
  Adjustments to documentation (spf13#1656)
  Rename Powershell completion tests (spf13#1803)
  Support for case-insensitive command names (spf13#1802)
  Deprecate ExactValidArgs() and test combinations of args validators (spf13#1643)
  Use correct stale action `exempt-` yaml keys (spf13#1800)
  With go 1.18, we must use go install for a binary (spf13#1726)
  Clarify SetContext documentation (spf13#1748)
  ci: test on Golang 1.19 (spf13#1782)
  fix: show flags that shadow parent persistent flag in child help (spf13#1776)
  Update gopkg.in/yaml.v2 to gopkg.in/yaml.v3 (spf13#1766)
  fix(bash-v2): activeHelp length check syntax (spf13#1762)
  fix: correct command path in see_also for YAML doc (spf13#1771)
  build(deps): bump github.com/inconshreveable/mousetrap (spf13#1774)
  docs: add zitadel to the list (spf13#1772)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/go General Go things, like go.mod or go.sum kind/testing CI/CD, testing, etc. for cobra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants