Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gopkg.in/yaml.v2 to gopkg.in/yaml.v3 #1766

Merged
merged 1 commit into from Aug 13, 2022
Merged

Conversation

tklauser
Copy link
Contributor

API v3 was released in 2019 [1]. Update from the v2 API, no changes to
the packages's use needed and no breaking changes expected.

[1] https://ubuntu.com/blog/api-v3-of-the-yaml-package-for-go-is-available

API v3 was released in 2019 [1]. Update from the v2 API, no changes to
the packages's use needed and no breaking changes expected.

[1] https://ubuntu.com/blog/api-v3-of-the-yaml-package-for-go-is-available
@github-actions github-actions bot added area/docs-generation Generation of docs via Cobra size/XS Denotes a PR that changes 0-9 lines labels Jul 26, 2022
Copy link
Contributor

@umarcor umarcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jpmcb jpmcb self-assigned this Jul 30, 2022
@jpmcb
Copy link
Collaborator

jpmcb commented Jul 30, 2022

I'd like to take a look at this and quickly compare some diffs of docs generated via v2 and v3 - but we should be able to get this in with no problem!

Copy link

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to do a sanity check of the output (I have not) but this looks good to me and from what I've seen elsewhere should be safe.

jpmcb
jpmcb approved these changes Aug 13, 2022
@jpmcb jpmcb merged commit dbf85f6 into spf13:main Aug 13, 2022
15 checks passed
@umarcor
Copy link
Contributor

umarcor commented Aug 13, 2022

@marckhouzam please milestone this as well!

@marckhouzam marckhouzam added this to the 1.6.0 milestone Aug 13, 2022
@tklauser tklauser deleted the yaml-v3 branch August 14, 2022 07:16
jimschubert added a commit to jimschubert/cobra that referenced this pull request Oct 3, 2022
* main: (39 commits)
  Add '--version' flag to Help output (spf13#1707)
  Expose ValidateRequiredFlags and ValidateFlagGroups (spf13#1760)
  Document option to hide the default completion cmd (spf13#1779)
  ci: add workflow_dispatch (spf13#1387)
  add missing license headers (spf13#1809)
  ci: use action/setup-go's cache (spf13#1783)
  Adjustments to documentation (spf13#1656)
  Rename Powershell completion tests (spf13#1803)
  Support for case-insensitive command names (spf13#1802)
  Deprecate ExactValidArgs() and test combinations of args validators (spf13#1643)
  Use correct stale action `exempt-` yaml keys (spf13#1800)
  With go 1.18, we must use go install for a binary (spf13#1726)
  Clarify SetContext documentation (spf13#1748)
  ci: test on Golang 1.19 (spf13#1782)
  fix: show flags that shadow parent persistent flag in child help (spf13#1776)
  Update gopkg.in/yaml.v2 to gopkg.in/yaml.v3 (spf13#1766)
  fix(bash-v2): activeHelp length check syntax (spf13#1762)
  fix: correct command path in see_also for YAML doc (spf13#1771)
  build(deps): bump github.com/inconshreveable/mousetrap (spf13#1774)
  docs: add zitadel to the list (spf13#1772)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs-generation Generation of docs via Cobra size/XS Denotes a PR that changes 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants