New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: obey SOURCE_DATE_EPOCH with manpage generation #735

Merged
merged 1 commit into from Oct 21, 2018

Conversation

Projects
None yet
3 participants
@cyphar
Contributor

cyphar commented Aug 23, 2018

Previously if a cobra user didn't specify an explicit .Date header, the
current time would be included in all of the generated man pages each
time they were built. This causes an issue for reproducible builds,
since each re-build of a package that includes the man pages will have
different times listed in the man pages.

To fix this, add support for SOURCE_DATE_EPOCH (which is a standardised
packaging environment variable, designed to be used specifically for
this purpose
).

Signed-off-by: Aleksa Sarai asarai@suse.de

@CLAassistant

This comment has been minimized.

CLAassistant commented Aug 23, 2018

CLA assistant check
All committers have signed the CLA.

doc: obey SOURCE_DATE_EPOCH with manpage generation
Previously if a cobra user didn't specify an explicit .Date header, the
current time would be included in all of the generated man pages each
time they were built. This causes an issue for reproducible builds,
since each re-build of a package that includes the man pages will have
different times listed in the man pages.

To fix this, add support for SOURCE_DATE_EPOCH (which is a standardised
packaging environment variable, designed to be used specifically for
this purpose[1]).

[1]: https://reproducible-builds.org/specs/source-date-epoch/

Signed-off-by: Aleksa Sarai <asarai@suse.de>

@eparis eparis merged commit fe5e611 into spf13:master Oct 21, 2018

5 checks passed

ci/circleci: go-current Your tests passed on CircleCI!
Details
ci/circleci: go-latest Your tests passed on CircleCI!
Details
ci/circleci: go-previous Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@cyphar cyphar deleted the cyphar:obey-source_date_epoch branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment