Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply formatting to templates #980

Merged
merged 1 commit into from Dec 23, 2019
Merged

Conversation

jharshman
Copy link
Collaborator

@jharshman jharshman commented Oct 19, 2019

Apply Go formatting to templates

Currently, after templates are generated, gofmt has to be run against the files in order to properly format them.

Goal here is to have the output of the templates not need additional formatting to fall in line with Go standard format.

@jharshman jharshman added the kind/feature label Oct 19, 2019
@jharshman jharshman added this to the 1.0.0 milestone Oct 19, 2019
@jharshman
Copy link
Collaborator Author

@jharshman jharshman commented Oct 19, 2019

Failing on the comparison with the "golden" files. Fixing...

@umarcor
Copy link
Contributor

@umarcor umarcor commented Oct 20, 2019

Close #933
Ref #876

@jharshman jharshman merged commit 447f182 into spf13:master Dec 23, 2019
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants