[bug] Emoji not parsed on certain text patterns #2198

Closed
revelt opened this Issue Jun 11, 2016 · 3 comments

Projects

None yet

3 participants

@revelt
Contributor
revelt commented Jun 11, 2016

Hi all,

There is a bug in the emoji rendering, probably related to #1892. My post content with emoji is sometimes parsed, sometimes not, and I distilled the following:

  • Emoji are not parsed when the colon character is being present
  • If the text after comma is short enough, emoji renders fine, no matter is there a colon or not

See this:
hugo-emoji-bug

Try copy-pasting into your sites to test:

Aaaaaaaaaa: aaaaaaaaaa aaaaaaaaaa aaaaaaaaaa.

:rocket:

In practice, my blog articles contain some colon characters and emoji are not being parsed on the whole article. By the way, I'm using the latest Hugo v0.16 from Brew.

@bep bep added the kind/bug label Jun 11, 2016
@bep bep added a commit that closed this issue Jun 11, 2016
@bep bep Fix Emojfy for certain text patterns
Fixes #2198
2564f46
@bep bep closed this in 2564f46 Jun 11, 2016
@memiks
memiks commented Jul 1, 2016

Hello,

Ok but I try my text with master source code without success...
After the merge of your commit.

You can test if you want.

Best regards,
Memiks.

@bep
Collaborator
bep commented Jul 1, 2016

I did: aa66478

Are you saying there are other failing test cases?

@revelt
Contributor
revelt commented Jul 1, 2016

I'd help testing, but I'm not good at compiling. I'm still at 0.16 first release...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment