Remove unneeded casts in page.getParam #2186

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@sambooo
Contributor
sambooo commented Jun 6, 2016 edited

Some calls to cast.To in getParam are no-ops that can be removed, since they just add type information that is discarded on return

@CLAassistant
CLAassistant commented Jun 6, 2016 edited

CLA assistant check
All committers have signed the CLA.

@moorereason
Collaborator

Curious how you found these. Are you using a linter?

@sambooo
Contributor
sambooo commented Jun 6, 2016

Just caught my eye when looking at Page's implementation. Why do you ask?

@moorereason
Collaborator

Then you have a good eye. 👍 I was asking about the linter because I don't know of an existing linter that would detect that issue.

lgtm

sambooo added some commits Jun 6, 2016
@sambooo sambooo Remove unused packages from Dockerfile
d9496dc
@sambooo sambooo Remove unneeded casts in page.getParam
f29cd42
@sambooo
Contributor
sambooo commented Jun 6, 2016

Force pushed to my fork like an idiot and got another commit stuck in the mix, no changes in the new version

@bep bep added a commit that closed this pull request Jun 9, 2016
@sambooo @bep sambooo + bep Remove unneeded casts in page.getParam
Closes #2186
75deb92
@bep bep closed this in 75deb92 Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment