Fix shortcode in markdown headers #2210

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@bep
Collaborator
bep commented Jun 13, 2016

This issue was introduced as a fix to shortcode not working in RST.

One could argue that Blackfriday and friends should handle # in titles, but that will be a discussion
for another day.

The new placeholder pattern should be RST safe and work with titles.

And now with a test so this doesn't break again.

Fixes #2192
Fixes #2209

@bep bep Fix shortcode in markdown headers
This issue was introduced as a fix to shortcode not working in RST.

One could argue that Blackfriday and friends should handle `#` in titles, but that will be a discussion
for another day.

The new placeholder pattern should be RST safe and work with titles.

And now with a test so this doesn't break again.

Fixes #2192
Fixes #2209
ddcc1ed
@bep
Collaborator
bep commented Jun 13, 2016

See #1904 for the RST issue.

@moorereason
Collaborator

lgtm

@bep bep added a commit that closed this pull request Jun 15, 2016
@bep bep Fix shortcode in markdown headers
This issue was introduced as a fix to shortcode not working in RST.

One could argue that Blackfriday and friends should handle `#` in titles, but that will be a discussion
for another day.

The new placeholder pattern should be RST safe and work with titles.

And now with a test so this doesn't break again.

Fixes #2192
Fixes #2209
Closes #2210
34f4004
@bep bep closed this in 34f4004 Jun 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment