Enable safeHTMLAttr #2234

Closed
wants to merge 1 commit into
from

Projects

None yet

5 participants

@webguerilla
Contributor
webguerilla commented Jun 22, 2016 edited

Hi together,

I'm using Hugo shortcodes to generate HTML forms from JSON. I like to set HTML attributes dynamically, but was not able to do so because the attributes were replaced with "ZgotmplZ". The template functions safeHTML, etc. did not work.

After some research I found the template function "safeHTMLAttr", which was already implemented, but disabled, because the developer has seen no use case for it. See #347 (comment)

I have now enabled the function again, because it would be really useful for me. If you like to merge it, I could also write a test and improve the documentation.

Best regards,
Marco

@webguerilla webguerilla enabled safeHTMLAttr
7af71f9
@CLAassistant
CLAassistant commented Jun 22, 2016 edited

CLA assistant check
All committers have signed the CLA.

@moorereason
Collaborator

I like this PR. We live in the Go Template world with it's features and quirks. We should give users the tools they need to build whatever they want.

@bep
Collaborator
bep commented Jun 22, 2016

I like it, too.

@anthonyfok anthonyfok added a commit that referenced this pull request Jun 27, 2016
@webguerilla @anthonyfok webguerilla + anthonyfok tpl: Enable safeHTMLAttr
See #2234 and #347
c21e2b3
@anthonyfok
Collaborator

Ditto. :-) Looking back at #347, it seems silly to me that I would have been so overly cautious back then. So, let's merge it! It's long overdue.

Merged as c21e2b3 after amending the commit message per the contribution guideline.
Thank you for your contribution, @webguerilla!

@anthonyfok anthonyfok closed this Jun 27, 2016
@anthonyfok anthonyfok added this to the v0.17 milestone Jun 27, 2016
@webguerilla
Contributor

@anthonyfok Thank you for merging, however I have not contributed much, just uncommented your work 😃

@anthonyfok
Collaborator

@webguerilla Thank you for your compliments! But the credit actually goes to @tatsushid who contributed this feature in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment