source: Normalize file name to NFC #2259

Merged
merged 1 commit into from Aug 8, 2016

Projects

None yet

2 participants

@ks888
Contributor
ks888 commented Jul 6, 2016

Fixes #2203

@bep
Collaborator
bep commented Jul 11, 2016

This didn't fix my problem.

Darwin bep-mac.local 15.5.0 Darwin Kernel Version 15.5.0: Tue Apr 19 18:36:36 PDT 2016; root:xnu-3248.50.21~8/RELEASE_X86_64 x86_64
@bep
Collaborator
bep commented Jul 11, 2016 edited

This did spf13/fsync#8

@ks888
Contributor
ks888 commented Jul 16, 2016

Sorry this PR does not fix your issue. This PR works if an image file is under the /content/ directory. I guess your image file is under the /static/ directory, so this PR does not work.

Actually, this PR can fix the case a file (including markdown) under the /content/ directory has å character. So I think this PR is still useful for non-English speakers like me.

@ks888 ks888 source: Normalize file name to NFC
Fixes #2203
6c4c3f2
@ks888
Contributor
ks888 commented Aug 1, 2016

@bep I fixed the merge conflict. Could you take a look this PR again?

@bep bep merged commit 39df772 into spf13:master Aug 8, 2016

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/wercker Wercker build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment