added BundleInstall to the windows installer .cmd file #168

Merged
merged 2 commits into from Oct 12, 2012

Conversation

Projects
None yet
3 participants
@jhnwsk
Contributor

jhnwsk commented Oct 11, 2012

Hi Steve,

I installed on XP today and found that for some reason the .cmd script does not call BundleInstall. After I launched vim it threw lots of red letters at me.

Fix is pretty simple. I tested on XP only.

cheers,
John

@jhnwsk

This comment has been minimized.

Show comment Hide comment
@jhnwsk

jhnwsk Oct 11, 2012

Contributor

I think this behaviour is the reason for #167.

Contributor

jhnwsk commented Oct 11, 2012

I think this behaviour is the reason for #167.

@kevinwaddle

This comment has been minimized.

Show comment Hide comment
@kevinwaddle

kevinwaddle Oct 11, 2012

Contributor

Wouldn't this need '-u "$BASE_DIR/.vimrc.bundles"' fed in as well?

call vim -u "$BASE_DIR/.vimrc.bundles" - +BundleInstall! +BundleClean +qall

Contributor

kevinwaddle commented Oct 11, 2012

Wouldn't this need '-u "$BASE_DIR/.vimrc.bundles"' fed in as well?

call vim -u "$BASE_DIR/.vimrc.bundles" - +BundleInstall! +BundleClean +qall

@spf13

This comment has been minimized.

Show comment Hide comment
@spf13

spf13 Oct 11, 2012

Owner

I'm traveling and won't be back to my windows machine for a couple days so really appreciate the help from others.

This is accurate and should match the final call in the bootstrap.sh

Steve Francia
@spf13

On Thursday, October 11, 2012 at 10:25 AM, kevinwaddle wrote:

Wouldn't this need '-u "$BASE_DIR/.vimrc.bundles"' fed in as well?
call vim -u "$BASE_DIR/.vimrc.bundles" - +BundleInstall! +BundleClean +qall


Reply to this email directly or view it on GitHub (#168 (comment)).

Owner

spf13 commented Oct 11, 2012

I'm traveling and won't be back to my windows machine for a couple days so really appreciate the help from others.

This is accurate and should match the final call in the bootstrap.sh

Steve Francia
@spf13

On Thursday, October 11, 2012 at 10:25 AM, kevinwaddle wrote:

Wouldn't this need '-u "$BASE_DIR/.vimrc.bundles"' fed in as well?
call vim -u "$BASE_DIR/.vimrc.bundles" - +BundleInstall! +BundleClean +qall


Reply to this email directly or view it on GitHub (#168 (comment)).

@jhnwsk

This comment has been minimized.

Show comment Hide comment
@jhnwsk

jhnwsk Oct 12, 2012

Contributor

Yeap you are right Kevin.

Contributor

jhnwsk commented Oct 12, 2012

Yeap you are right Kevin.

spf13 added a commit that referenced this pull request Oct 12, 2012

Merge pull request #168 from jhnwsk/windows-installer-fix
added BundleInstall to the windows installer .cmd file

@spf13 spf13 merged commit c5faeaf into spf13:3.0 Oct 12, 2012

vito-c pushed a commit to vito-c/pirate-vim-deprecated that referenced this pull request Mar 19, 2013

Merge pull request #168 from jhnwsk/windows-installer-fix
added BundleInstall to the windows installer .cmd file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment