Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gorilla dependency #899

Merged
merged 2 commits into from Apr 21, 2020
Merged

Update gorilla dependency #899

merged 2 commits into from Apr 21, 2020

Conversation

@jpmcb
Copy link
Contributor

@jpmcb jpmcb commented Apr 21, 2020

This dependency bump is in reference to #898 and spf13/cobra#1091

Bumps to the latest patch version of gorilla/websocket 1.4

Let me know if there are questions!

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Apr 21, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@sagikazarmark sagikazarmark left a comment

Although I'm not convinced that this is necessary to update in Viper (MVS and semantic import versioning gives full control to applications), especially since it's just an indirect dependency.

But it's probably for the best, so thanks!

@sagikazarmark sagikazarmark merged commit c42a305 into spf13:master Apr 21, 2020
4 checks passed
4 checks passed
@github-actions
Build (1.11)
Details
@github-actions
Build (1.12)
Details
@github-actions
Build (1.13)
Details
license/cla Contributor License Agreement is signed.
Details
@jpmcb jpmcb deleted the jpmcb:update-deps branch Apr 21, 2020
@DarthHater
Copy link

@DarthHater DarthHater commented Apr 21, 2020

@sagikazarmark it's just good to know someone cares :)

Thanks for doing this!

brainexe added a commit to brainexe/viper that referenced this pull request Nov 12, 2020
* Update gorilla dependency

* Run go mod tidy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants