Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix abs pathify #940

Merged
merged 2 commits into from Jul 31, 2020
Merged

Fix abs pathify #940

merged 2 commits into from Jul 31, 2020

Conversation

@qjcg
Copy link
Contributor

@qjcg qjcg commented Jul 31, 2020

I've created a new PR to address the path expansion issue first reported by @biochimia in #495.

This PR simply adds requested changes to speed things along. CC: @sagikazarmark

Fixes #495

biochimia and others added 2 commits May 6, 2018
- Don't expand user home directory for variable names that simply have a
  HOME prefix;
- Support expansion of variables not followed by the path separator.
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Jul 31, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@sagikazarmark sagikazarmark left a comment

LGTM, thanks @qjcg

@sagikazarmark sagikazarmark merged commit 3826be3 into spf13:master Jul 31, 2020
5 checks passed
5 checks passed
@github-actions
Build (1.11)
Details
@github-actions
Build (1.12)
Details
@github-actions
Build (1.13)
Details
@github-actions
Build (1.14)
Details
license/cla Contributor License Agreement is signed.
Details
@sagikazarmark
Copy link
Collaborator

@sagikazarmark sagikazarmark commented Jul 31, 2020

Tagged v1.7.1 with the fix.

@biochimia
Copy link
Contributor

@biochimia biochimia commented Aug 2, 2020

Thanks for moving this forward!

@qjcg
Copy link
Contributor Author

@qjcg qjcg commented Aug 3, 2020

@biochimia Cheers, thanks for all of your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants