From 07f1a6d84dcfb4c43dbdffef07c130f9332ef279 Mon Sep 17 00:00:00 2001 From: "Nathaniel J. Smith" Date: Sat, 6 May 2017 21:27:31 -0700 Subject: [PATCH] Stop enforcing that favicon's must be .ico Support for at least .png and .gif is now essentially universal, and other formats (.jpg, .svg, etc.) are relatively widespread. This was only a warning, but it's common to run sphinx with warnings turned into errors, so it caused problems. --- sphinx/builders/html.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/sphinx/builders/html.py b/sphinx/builders/html.py index 253849b922b..b886b76424c 100644 --- a/sphinx/builders/html.py +++ b/sphinx/builders/html.py @@ -305,8 +305,6 @@ def prepare_writing(self, docnames): favicon = self.config.html_favicon and \ path.basename(self.config.html_favicon) or '' - if favicon and os.path.splitext(favicon)[1] != '.ico': - self.warn('html_favicon is not an .ico file') if not isinstance(self.config.html_use_opensearch, string_types): self.warn('html_use_opensearch config value must now be a string')