New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilds regenerate searchindex.js -- causes bad search results #3270

Open
Blendify opened this Issue Dec 21, 2016 · 8 comments

Comments

Projects
None yet
5 participants
@Blendify
Contributor

Blendify commented Dec 21, 2016

Subject: Rebuilds regenerate searchindex.js -- causes bad search results

Problem

In the pass we have had a lot of issues with using the sphinx search. Until today I had no idea why but after debugging it all of today I found the issue. Before noticing this we would update our documentation on our server by only doing a rebuild. However, when sphinx does this it regenerates searchindex.js

Procedure to reproduce the problem

Using the makes files on a project of your choice:

make clean
make html

Try searching for a term that should return a specific page. Then make a change on any other file that does not have anything to do with the term you searched for.

make html

Try to search for that term again.

Error logs / results

No error logs are generated.

The results are that the search does not work.

Expected results

Doing a rebuild should not regenerate the searchindex.js using only the modified files.

Reproducible project / your project

Our project can be found at: https://developer.blender.org/project/view/53/
With the source code at https://developer.blender.org/diffusion/BM/

Environment info

  • OS: Win10, Elementary OS, FreeBSD
  • Python version: 3.5.1
  • Sphinx version: 1.5.1
@ThomasWaldmann

This comment has been minimized.

Show comment
Hide comment
@ThomasWaldmann

ThomasWaldmann Dec 21, 2016

I can confirm.

Just running "make html" makes search results vanish that are there when running "make clean html".

I tested it using Sphinx 1.4.5.

ThomasWaldmann commented Dec 21, 2016

I can confirm.

Just running "make html" makes search results vanish that are there when running "make clean html".

I tested it using Sphinx 1.4.5.

@gplanansky

This comment has been minimized.

Show comment
Hide comment
@gplanansky

gplanansky Jun 16, 2017

confirm using Sphinx 1.5.2: "make html" makes search results vanish that are there with "make clean" followed by "make html".

gplanansky commented Jun 16, 2017

confirm using Sphinx 1.5.2: "make html" makes search results vanish that are there with "make clean" followed by "make html".

@tk0miya tk0miya added the bug label Jun 17, 2017

@tk0miya tk0miya added this to the 1.6.4 milestone Jun 17, 2017

@tk0miya tk0miya modified the milestones: 1.6.4, 1.6.5 Sep 24, 2017

@tk0miya

This comment has been minimized.

Show comment
Hide comment
@tk0miya

tk0miya Oct 21, 2017

Member

I can't still reproduce this locally. Can anyone tell me a procedure to reproduce in detail?

Member

tk0miya commented Oct 21, 2017

I can't still reproduce this locally. Can anyone tell me a procedure to reproduce in detail?

@tk0miya tk0miya modified the milestones: 1.6.5, 1.6.6 Oct 21, 2017

@Blendify

This comment has been minimized.

Show comment
Hide comment
@Blendify

Blendify Oct 21, 2017

Contributor

With any docs:

  1. make clean
  2. make html
  3. Open Docs and search for a term that would be expected to be found on one page.
  4. Edit another page that does not have that term
  5. make html
  6. Search for that term again it will not appear.
Contributor

Blendify commented Oct 21, 2017

With any docs:

  1. make clean
  2. make html
  3. Open Docs and search for a term that would be expected to be found on one page.
  4. Edit another page that does not have that term
  5. make html
  6. Search for that term again it will not appear.

@tk0miya tk0miya modified the milestones: 1.6.6, 1.6.7 Jan 7, 2018

@takuan-osho

This comment has been minimized.

Show comment
Hide comment
@takuan-osho

takuan-osho Jan 7, 2018

Contributor

FYI: I tried to reproduce this issue with cloning and using Blender Manual, but I couldn't reproduce it. I follewed this instruction.

Environment info

  • OS: macOS 10.12.6
  • Python version: 3.6.3
  • Sphinx version: 1.6.5

Because I couldn't build blender manual with Sphinx 1.5.1, I used Sphinx 1.6.5.

Contributor

takuan-osho commented Jan 7, 2018

FYI: I tried to reproduce this issue with cloning and using Blender Manual, but I couldn't reproduce it. I follewed this instruction.

Environment info

  • OS: macOS 10.12.6
  • Python version: 3.6.3
  • Sphinx version: 1.6.5

Because I couldn't build blender manual with Sphinx 1.5.1, I used Sphinx 1.6.5.

@Blendify

This comment has been minimized.

Show comment
Hide comment
@Blendify

Blendify Jan 7, 2018

Contributor
Contributor

Blendify commented Jan 7, 2018

@tk0miya tk0miya added the help wanted label Jan 27, 2018

@tk0miya tk0miya modified the milestones: 1.6.7, 1.7.1 Jan 30, 2018

@gplanansky

This comment has been minimized.

Show comment
Hide comment
@gplanansky

gplanansky Feb 4, 2018

I do not see this issue with 1.6.3 (provided with an anaconda3 package). I do not have observations for other versions (than 1.5.2).

gplanansky commented Feb 4, 2018

I do not see this issue with 1.6.3 (provided with an anaconda3 package). I do not have observations for other versions (than 1.5.2).

@gplanansky

This comment has been minimized.

Show comment
Hide comment
@gplanansky

gplanansky Feb 4, 2018

gplanansky commented Feb 4, 2018

@tk0miya tk0miya modified the milestones: 1.7.1, 1.7.2 Feb 17, 2018

@tk0miya tk0miya modified the milestones: 1.7.2, 1.7.3 Mar 18, 2018

@tk0miya tk0miya removed this from the 1.7.3 milestone Apr 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment