Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remote image URIs without filename break HTML builds in 1.6.2 #3860
Subject: Remote image URIs without filename break HTML builds in 1.6.2
Procedure to reproduce the problem
Attempt building a project which includes an image like the above in a file, such as README.rst, using Sphinx 1.6.2. i.e.:
https://readthedocs.org/projects/awslimitchecker/badge/?version=latest actually redirects to https://img.shields.io/badge/docs-latest-brightgreen.svg?style=flat - the URL checks the status of the docs build for the specified version, and redirects to an appropriate shields.io badge.
Error logs / results
From what I can tell, the problem seems to be in sphinx.transforms.post_transforms.images.ImageDownloader.handle as introduced in #3589, as the local paths that it generates do not work for images without a filename (
Expected these images to download correctly without a problem, as they did under 1.5.5
Reproducible project / your project
I can not reproduce your problem with minimal index.rst containing only
on mac os. Also tested with Python 3.5.3.
Well, sorry again,
Or simply one gets the warning via
Looks as if linkcheck needs update