Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.6 support #10468

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Drop python 3.6 support #10468

merged 1 commit into from
Jun 16, 2022

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented May 22, 2022

Feature or Bugfix

  • Refactoring

Purpose

  • Based on our "Python version support policy", python3.6 support will be ended at 2023.04.
  • This drops the support from the master branch used for development for v6.0.
  • I'll also drop python 3.7 support on the next PR.
  • This only drops the code for py36. It would be better to refactor with new syntax, libraries and so on after clean up.

@tk0miya tk0miya added this to the 6.0.0 milestone May 22, 2022
@@ -10,8 +10,6 @@ jobs:
fail-fast: false
matrix:
include:
- python: "3.6"
docutils: du14
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Ubuntu-20.04 distributes docutils-0.16. So it will be the new supported base version. I'll work on it after merging this.
https://packages.ubuntu.com/focal/python3-docutils

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to increase the minimum requirement to Docutils 0.18? There are lots of patches in Sphinx for Docutils 0.17 or earlier, and it would be nice to remove those at the same time as we drop end-of-life Python versions.

As far as I can tell the current Sphinx version support policy only makes reference to Ubuntu for Python versions, not for Docutils.

A

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my thought, it's simple to refer to Ubuntu LTS to decide the version of dependencies. I feel dropping dependency does not help our work. So -0 for your proposal

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel dropping dependency does not help our work.

We could take a view to support every version of Python / Docutils perpeptually, and just accumulate a lot of patches. I personally find it harder to reason about the code when there are multiple layers of patches etc, especially ones that monkeypatch Docutils, hence looking to bump the version higher and remove code.

I'd argue we should look to make things simpler for ourselves as maintainers where possible - Ubuntu is a re-distributor and will cope with decisions that we make under their policies, but I don't think we should be somewhat arbitrarily bound by them when there are significant code simplifications from the bump to 0.18.

A

@tk0miya tk0miya force-pushed the drop_py36 branch 4 times, most recently from adc57be to 26c0d01 Compare May 22, 2022 18:18
@tk0miya
Copy link
Member Author

tk0miya commented May 26, 2022

Does this conflict with #10470? May I merge this?

@AA-Turner
Copy link
Member

Does this conflict with #10470? May I merge this?

It probably does, but I'd say merge this first and then I'll deal with the conflicts and rebase #10470.

A

@danieleades
Copy link
Contributor

you might want to consider running pyupgrade over these deprecation PRs

https://pypi.org/project/pyupgrade/

@AA-Turner
Copy link
Member

I ran pyupgrade locally on my larger refactoring branch (https://github.com/AA-Turner/sphinx/commits/drop-py37-refactoring) -- this should probably stay more focussed.

A

@AA-Turner AA-Turner merged commit 7e68154 into sphinx-doc:master Jun 16, 2022
@AA-Turner
Copy link
Member

I will rebase #10470 on master.

A

AA-Turner pushed a commit to AA-Turner/sphinx that referenced this pull request Jun 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants