Remove support for pluralisation during gettext resource translation

[jayaddison]

Change type

• Cleanup

Purpose

• During development of Disable localisation when SOURCE_DATE_EPOCH is set #10949, code related to ngettext (support for n-ary / plural forms of translated text) was modified in the codebase, and following on from that, I spent some time investigating whether that's used. It doesn't appear to be, so this pull request offers a possible cleanup by removing the ngettext reference

Detail

• ngettext allows an application to provide a dynamic number (often a count of items, like '5' in the linter produced 5 warnings) to the translation query so that a plurality-relevant message can be retrieved from the catalog
• sphinx has previously used this within its own codebase, but no longer does -- babel command-line extraction is used to retrieve translatable resources from the codebase, and extraction of plural-form keywords is not configured (nor easy to enable, as far as I could tell)
• As a result it seems like it may make sense to remove the code

Relates

• Disable localisation when SOURCE_DATE_EPOCH is set #10949

[AA-Turner]

Thanks!

A

[jayaddison]

Thanks @AA-Turner!