Remove all memory addresses in object_description() #2534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I will merge this within a few days if no objections. |
|
Now this is merged into master. so it will be released in major release (v1.5). |
ghost
mentioned this pull request
|
#2647 has been merged instead (to stable). |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 11, 2016
Since recently, we are using more of the upstream version of `autodoc`. This also has some code to remove hexadecimal address (see #19858) but the regular expression is too strict. This can easily be fixed, see sphinx-doc/sphinx#2534. URL: http://trac.sagemath.org/20574 Reported by: jdemeyer Ticket author(s): Jeroen Demeyer Reviewer(s): François Bissey
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Change
object_desription()to remove all hexadecimal addresses, not only those at the end of the string.The
repr()of some objects is generated by taking therepr()of one object and then adding stuff to it. Therefore, memory addresses like<object foo at 0xabcdef>do not need to occur at the end of the string.