Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3722 Make memory address regex more permissive. #3897

Closed
wants to merge 1 commit into from

Conversation

pkmoore
Copy link

@pkmoore pkmoore commented Jun 28, 2017

Subject: Make the memory address regular expression in sphinx/util/inspect.py more permissive. This change allows memory addresses preceded by a colon to be removed which helps projects using sphinx generate more reproducible documentation and builds.

Feature or Bugfix

  • Bugfix

Purpose

Strip more memory addresses to help build reproducibility.

Relates

#3722

@tk0miya
Copy link
Member

tk0miya commented Jun 30, 2017

I think this is not "permissive". This is a special hack only for django-celery.
AFAIK, its repr format is not standard. Please tell me if the format is commonly used.

If you mean sphinx should support non-standard repr format, we need to discuss how to support it.
At least, it should be more extensible way.

@tk0miya
Copy link
Member

tk0miya commented Jul 17, 2017

As I commented above, this is not good to merge.
If you have comment, please post it to #3722

Thanks,

@tk0miya tk0miya closed this Jul 17, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants