Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epub: Sort manifest entries by filename #3972

Merged
merged 1 commit into from Sep 4, 2017
Merged

Conversation

@bmwiedemann
Copy link
Contributor

bmwiedemann commented Aug 1, 2017

is a fixup on commit 0b7c73a

is required because the os.walk loop is run per directory
and the ordering of directories is indeterministic

@bmwiedemann bmwiedemann force-pushed the bmwiedemann:epubsort branch from 1399dcf to d93b4c0 Aug 1, 2017
@tk0miya

This comment has been minimized.

Copy link
Member

tk0miya commented Aug 8, 2017

Tests are failed. could you check them please?

@tk0miya tk0miya added the epub label Aug 8, 2017
@tk0miya

This comment has been minimized.

Copy link
Member

tk0miya commented Aug 8, 2017

In addition, you'd like to add this change to next stable release, please rebase this to stable branch.

is a fixup on commit 0b7c73a

is required because the os.walk loop is run per directory
and the ordering of directories is indeterministic
@bmwiedemann bmwiedemann force-pushed the bmwiedemann:epubsort branch from d93b4c0 to 3164e27 Aug 21, 2017
@bmwiedemann

This comment has been minimized.

Copy link
Contributor Author

bmwiedemann commented Aug 21, 2017

made the existing tests pass with a much simpler patch

@tk0miya tk0miya merged commit fb24ea3 into sphinx-doc:master Sep 4, 2017
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tk0miya

This comment has been minimized.

Copy link
Member

tk0miya commented Sep 4, 2017

Thank you for update!
Merged.

tk0miya added a commit that referenced this pull request Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.