Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Ensure the graphviz filenames are reproducible #6028
Whilst working on the Reproducible Builds effort, we noticed that sphinx could generate output that is not reproducible.
In particular, the graphviz extension module would construct filenames based on, inter alia, the contents of the
As this contained the absolute build path of the source file embedded in the
Example filenames might be:
We fix this by limiting how much of the
@@ Coverage Diff @@ ## master #6028 +/- ## ========================================== + Coverage 82.91% 82.93% +0.02% ========================================== Files 271 269 -2 Lines 39086 39054 -32 Branches 5847 5844 -3 ========================================== - Hits 32408 32391 -17 + Misses 5330 5318 -12 + Partials 1348 1345 -3
I want to note that your patch actually omits all options except the filename. Though in my opinion it is fine, as the resulting image depends only on source file name and graphviz arguments, which are present in the hash anyway.