Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LaTeX: stop using extractbb for image inclusion in Japanese documents #6189

merged 1 commit into from Sep 5, 2019


Copy link

@jfbu jfbu commented Mar 19, 2019

Since TeXLive2015, the dvipdfmx binary does not need extra .xbb files
for images (which were produced using extractbb).

I propose to wait for Sphinx 3.0 because although a TeXLive2015-based TeX distribution is listed as requirement since Sphinx 2.0, it is not needed to really force users to upgrade only to help us trim a few lines on our side which are neither an added feature nor a bugfix but simply some steps which were mandatory in the past and are now not needed.

Or at least wait until we shift from platex to uplatex for Japanese projects (refs: #4187 (comment))

edit: I forgot to add this link for source of information about extractbb unneeded since TL2015.

Since TeXLive2015, the dvipdfmx binary does not need extra .xbb files
for images (which were produced using extractbb).
@jfbu jfbu added this to the some future version milestone Mar 19, 2019
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #6189 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6189   +/-   ##
  Coverage   83.47%   83.47%           
  Files         275      275           
  Lines       39461    39461           
  Branches     5886     5886           
  Hits        32941    32941           
  Misses       5167     5167           
  Partials     1353     1353

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6cc18c...0466f70. Read the comment docs.

Copy link

This is all Greek to me, but I personally have all of Adobes products.

Copy link

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, but current master branch is going forward v2.1.
At present, no appropriate branch for v3.0 there.

Copy link

tk0miya commented Mar 29, 2019

Now master branch is ready for 3.0!

@jfbu jfbu modified the milestones: some future version, 3.0.0 Apr 17, 2019
Copy link
Contributor Author

jfbu commented Sep 5, 2019

Thanks for reviewing! merging now that master is moving towards 3.0!

@jfbu jfbu merged commit 1174309 into sphinx-doc:master Sep 5, 2019
jfbu added a commit that referenced this pull request Sep 5, 2019
@jfbu jfbu deleted the latex_stop_using_extractbb branch September 6, 2019 07:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants