Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS, use more desc_sig_* nodes #9695

Merged
merged 8 commits into from Oct 5, 2021
Merged

Conversation

@jakobandersen
Copy link
Contributor

@jakobandersen jakobandersen commented Oct 2, 2021

Feature or Bugfix

  • Feature

Purpose

Update the Javascript domain to use more nodes for better CSS styling options.
See #9672 for more details on the background.

This also updates _pseudo_parse_arglist in the Python domain.

tk0miya
tk0miya approved these changes Oct 2, 2021
Copy link
Member

@tk0miya tk0miya left a comment

LGTM with nits.

sphinx/domains/javascript.py Outdated Show resolved Hide resolved
CHANGES Show resolved Hide resolved
sphinx/domains/javascript.py Outdated Show resolved Hide resolved
@jakobandersen jakobandersen merged commit c922189 into sphinx-doc:4.x Oct 5, 2021
16 checks passed
@jakobandersen jakobandersen deleted the js_nodes branch Oct 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants