New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name string_replace trips on projects with ".py" in path #322

Closed
nicain opened this Issue Dec 13, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@nicain
Contributor

nicain commented Dec 13, 2017

save_notebook(example_nb, src_file.replace('.py', '.ipynb'))

This code will trip on projects that have '.py' as a substring. I found this because I am working on a project called "aibs.pyproject_template". This will need a more exclusive replacement string.

@lesteve

This comment has been minimized.

Contributor

lesteve commented Dec 13, 2017

Oops sorry about that ... PR more than welcome! You may want to double-check that there are not more instances of this pattern across the whole codebase.

@nicain

This comment has been minimized.

Contributor

nicain commented Dec 19, 2017

@lesteve lesteve closed this in #331 Dec 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment