New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow and use https links where possible #258

Merged
merged 5 commits into from Jul 15, 2017

Conversation

Projects
None yet
4 participants
@QuLogic
Contributor

QuLogic commented Jun 29, 2017

Check for both http: and https: where necessary, and then use secure links in as many places as possible.

@QuLogic QuLogic referenced this pull request Jun 29, 2017

Closed

Sphinx gallery #902

@lesteve

This comment has been minimized.

Contributor

lesteve commented Jun 29, 2017

LGTM.

@Titan-C

This comment has been minimized.

Member

Titan-C commented Jun 29, 2017

Links over functions are not being recognized in python 2. See for example our Circle-CI build
https://107-25860190-gh.circle-artifacts.com/0/home/ubuntu/sphinx-gallery/rtd_html/auto_examples/plot_colors.html

@Titan-C

This comment has been minimized.

Member

Titan-C commented Jun 29, 2017

The links on source code not working in python 2 was introduced in #257. I'm reverting that

@dopplershift

This comment has been minimized.

Contributor

dopplershift commented Jun 29, 2017

Fixes #236.

@QuLogic QuLogic force-pushed the QuLogic:https branch from d909eeb to f3d1d78 Jun 30, 2017

@QuLogic

This comment has been minimized.

Contributor

QuLogic commented Jun 30, 2017

Rebased against latest master.

@Titan-C

This comment has been minimized.

Member

Titan-C commented Jul 15, 2017

LGTM. Links are back and using https.
Thank you. I'm merging this.

@Titan-C Titan-C merged commit 619139d into sphinx-gallery:master Jul 15, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@QuLogic QuLogic deleted the QuLogic:https branch Jul 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment