New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report version to sphinx. #292

Merged
merged 1 commit into from Oct 2, 2017

Conversation

Projects
None yet
5 participants
@anntzer
Contributor

anntzer commented Sep 10, 2017

Allows one to require a version from sphinx, see
http://www.sphinx-doc.org/en/stable/config.html#confval-needs_extensions
http://www.sphinx-doc.org/en/stable/extdev/index.html#extension-metadata

Not doing from . import __version__ as this would also set the version
of the submodule.

@larsoner

This comment has been minimized.

Contributor

larsoner commented Sep 11, 2017

Not doing from . import version as this would also set the version of the submodule.

It's probably better to do from . import __version__ as _sg_version or so to avoid this problem while still using relative imports

Report version to sphinx.
Allows one to require a version from sphinx, see
http://www.sphinx-doc.org/en/stable/config.html#confval-needs_extensions
http://www.sphinx-doc.org/en/stable/extdev/index.html#extension-metadata

Not doing `from . import __version__` as this would also set the version
of the submodule.

@anntzer anntzer force-pushed the anntzer:report-version-to-sphinx branch from 61b62f1 to c9eaef4 Sep 11, 2017

@anntzer

This comment has been minimized.

Contributor

anntzer commented Sep 11, 2017

sure, fixed

@Titan-C

This comment has been minimized.

Member

Titan-C commented Sep 11, 2017

It looks good.
Travis on py2 ubuntu failed. It is certainly unrelated to this. I refreshed the build, but we might need to pin seaborn or pandas version in this build until it passes.

@choldgraf

This comment has been minimized.

Contributor

choldgraf commented Sep 11, 2017

looks like 2.7 failed again...what should be done to get the fix in this PR?

@Titan-C

This comment has been minimized.

Member

Titan-C commented Sep 11, 2017

@GaelVaroquaux

This comment has been minimized.

Contributor

GaelVaroquaux commented Sep 11, 2017

@GaelVaroquaux

This comment has been minimized.

Contributor

GaelVaroquaux commented Oct 2, 2017

The failure is unrelated this PR is useful and good to go. Given that it has had approval above, I am merging.

@GaelVaroquaux GaelVaroquaux merged commit f33a97e into sphinx-gallery:master Oct 2, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@anntzer anntzer deleted the anntzer:report-version-to-sphinx branch Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment