New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Deactivate virtualenv provided by Travis #294

Merged
merged 1 commit into from Sep 22, 2017

Conversation

Projects
None yet
2 participants
@lesteve
Contributor

lesteve commented Sep 21, 2017

This should fix the Travis build failure seen in #292 (comment).

Travis provides numpy in its default virtual env and I am guessing that they upgraded the version recently. In any case we want to have control over the numpy we are using in this case the numpy from apt-get

I did some minor clean-ups in .travis.yml while I was at it.

@Titan-C

This comment has been minimized.

Member

Titan-C commented Sep 22, 2017

I'm surprised about Travis giving a numpy version in their virtual env which is more updated that the OS provided. In general Travis has very outdated versions of everything.
That though aside. This seems to solve our problems well enough, I'm merging this.

@Titan-C Titan-C merged commit 891540d into sphinx-gallery:master Sep 22, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lesteve

This comment has been minimized.

Contributor

lesteve commented Sep 22, 2017

Back in the days (when numpy wheels were not available for Linux) Travis did that for projects that had a dependency on numpy and were doing pip install numpy which would build numpy from source and take 5 minutes or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment