New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] ENH: only directive for downloads #298

Merged
merged 2 commits into from Oct 3, 2017

Conversation

Projects
None yet
3 participants
@GaelVaroquaux
Contributor

GaelVaroquaux commented Oct 3, 2017

Fixes #297

@larsoner

This comment has been minimized.

Contributor

larsoner commented Oct 3, 2017

Do we generate any PDFs in the tests / on CircleCI? Perhaps we should. We could maybe add it to the conf.py for #296 so we can easily inspect the output, but we'd have to be careful about LaTeX requirements.

@GaelVaroquaux

This comment has been minimized.

Contributor

GaelVaroquaux commented Oct 3, 2017

Adding LateX on Circle will increase the build times a lot. Are we sure that we want to do that?

@larsoner

This comment has been minimized.

Contributor

larsoner commented Oct 3, 2017

Are we sure that we want to do that?

I'll open a PR so we can see how much time/pain it adds :)

@GaelVaroquaux GaelVaroquaux changed the title from ENH: only directive for downloads to [MRG] ENH: only directive for downloads Oct 3, 2017

@larsoner

This comment has been minimized.

Contributor

larsoner commented Oct 3, 2017

When I rebase this on my intersphinx, do make latexpdf, and view it, I still see the:

Download Python source code:
Download Jupyter notebook:
plot_numpy_scipy.py
plot_numpy_scipy.ipynb
Gallery generated by Sphinx-Gallery

I don't understand how this is possible given the code. I assume you tested locally and it works for you?

@larsoner

This comment has been minimized.

Contributor

larsoner commented Oct 3, 2017

Oh actually it looks like a make clean fixes it. +1 for merge from me

@choldgraf

This comment has been minimized.

Contributor

choldgraf commented Oct 3, 2017

TIL about the only directive. neat!

@choldgraf choldgraf merged commit 3b5b3ae into sphinx-gallery:master Oct 3, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GaelVaroquaux

This comment has been minimized.

Contributor

GaelVaroquaux commented Oct 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment