Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
refactored py to ipynb #331
referenced this pull request
Dec 19, 2017
Thanks a lot for your PR! I remove the controversial changes and pushed a commit with additional minor tweaks.
Can you add a test in
I haven't jumped on the tox bandwagon yet although I have heard it is quite good. Minimal googling seems to indicate that conda and tox do not play nice together, oh well this will have to wait then ...
My 2 cents:
I just learned to use tox myself, and I love it. I use conda as well, but I can across a handy trick to use tox in a conda development env: create bare conda envs for the python versions you need tox to run against, and add them as symlinks to your path (for example ln -s /foo/envs/toxpy35/bin/python ./python 3.5, executed from ~/local/bin).
Ill stash the tox changes in a branch on my fork (https://github.com/nicain/sphinx-gallery/tree/enh/tox), in case you ever want to circle back to them.
@lesteve Any idea when the next patch revision number bump will occur, and be released to pypi? I have a project that would like SG to pip-install as a dependency, but need this fix for correct behavior. I Just need a rough timeline so that I can plan accordingly :)