New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: Allow title only -> use title as first paragraph #345

Merged
merged 1 commit into from Feb 9, 2018

Conversation

Projects
None yet
3 participants
@larsoner
Contributor

larsoner commented Feb 9, 2018

This makes an example description optional (title only is okay) by using the title as the description if it's not provided. The alternative is to just use '', but this seemed less useful given how the intro paragraph is used alter.

#232 was already fixed, this just adds an explicit test of it.

Closes #232.
Closes #222.

@choldgraf

This comment has been minimized.

Contributor

choldgraf commented Feb 9, 2018

nice! will wait for travis to be happy :-)

@codecov-io

This comment has been minimized.

codecov-io commented Feb 9, 2018

Codecov Report

Merging #345 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
+ Coverage   91.76%   91.87%   +0.11%     
==========================================
  Files          27       27              
  Lines        1833     1847      +14     
==========================================
+ Hits         1682     1697      +15     
+ Misses        151      150       -1
Impacted Files Coverage Δ
sphinx_gallery/tests/test_gen_rst.py 98.56% <100%> (+0.07%) ⬆️
sphinx_gallery/gen_rst.py 94.54% <100%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06adfe1...9a672a8. Read the comment docs.

@choldgraf choldgraf merged commit 2d5b7b1 into sphinx-gallery:master Feb 9, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 91.76%)
Details
codecov/project 91.87% (+0.11%) compared to 06adfe1
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@larsoner larsoner deleted the larsoner:titles branch Feb 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment