Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[MRG] Fix title detection logic. #356
I tried using sphinx-gallery from master in scikit-learn and I found that #345 introduces a regression in a edge case, where the title starts with a space, i.e. your example starts with something like this:
""" ====================== The title ====================== """
I also added more tests for extract_intro_and_title. The detection is based on regex and I feel is as good as the previous one. I tried a docutils based solution using
Note: to make a long story short, the title found by sphinx-gallery was empty before #345 but in practice this does not matter at all (except if you use ordering by title). The title for each example in the gallery is generated automatically by sphinx from a
@@ Coverage Diff @@ ## master #356 +/- ## ========================================== + Coverage 91.93% 92.08% +0.15% ========================================== Files 27 27 Lines 1834 1844 +10 ========================================== + Hits 1686 1698 +12 + Misses 148 146 -2