New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom default thumbnails in 'RGBA' space #375

Merged
merged 1 commit into from May 22, 2018

Conversation

Projects
None yet
5 participants
@padix-key
Contributor

padix-key commented May 11, 2018

This PR adds support for custom default thumbnails with transparency values. Up to now, the alpha value in RGBA PNG images is simply discarded, resulting in side effects like a black box surrounding the image.

@codecov-io

This comment has been minimized.

codecov-io commented May 11, 2018

Codecov Report

Merging #375 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #375   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files          27       27           
  Lines        1842     1842           
=======================================
  Hits         1696     1696           
  Misses        146      146
Impacted Files Coverage Δ
sphinx_gallery/gen_rst.py 95.67% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9817bf...a3d0ae8. Read the comment docs.

@padix-key

This comment has been minimized.

Contributor

padix-key commented May 11, 2018

To my knowledge, Matplotlib renders PNG images with solid white background. Therefore, this issue is not visible in the example gallery.

@Titan-C

This comment has been minimized.

Member

Titan-C commented May 11, 2018

This is probably good thing to have. I notice nevertheless that our broken stamp for the thumbnails becomes barely readable I tried putting a black background but it remains barely readable. Maybe we need to redo that image file.

@padix-key

This comment has been minimized.

Contributor

padix-key commented May 11, 2018

I like the transparent version of broken more than the one with the black background, but alternatively one could use something like a forbidden symbol.

@lesteve

This comment has been minimized.

Contributor

lesteve commented May 22, 2018

I don't fully understand the change but I have to admit I prefer the "Broken" image like this. Let's merge this one, thanks @padix-key!

@lesteve lesteve merged commit 2ed9e6b into sphinx-gallery:master May 22, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 92.07%)
Details
codecov/project 92.07% (+0%) compared to c9817bf
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Titan-C added a commit to Titan-C/sphinx-gallery that referenced this pull request Aug 10, 2018

Fix rebase issue
[MRG] Add note at the beginning of the example to the download section at the bottom (sphinx-gallery#362)

* Note at the beginning of the example linking to download section

* Add class to download link note

Update misleading doc about `download_all_examples` (sphinx-gallery#377)

Support for custom default thumbnails in 'RGBA' space (sphinx-gallery#375)

PEP 8

API: Refactor image scraping

FIX: str

FIX: Revert tinybuild changes

FIX: Fix doc

FIX: Fix example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment