New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Use unstyled pygments for output #384

Merged
merged 2 commits into from May 31, 2018

Conversation

Projects
None yet
3 participants
@larsoner
Contributor

larsoner commented May 29, 2018

We should probably use none as the markup language for outputs. This is more reflective of how they are rendered in the terminal (a key goal of SG). It also takes care of weird, unexpected formatting of log messages that the default python interpretation causes.

The only downside I can see is that reprs that were previously formated to look like Python objects no longer will be. But I'd argue this is reasonable behavior since this is more like what a terminal would display when you actually execute the commands.

@lesteve

This comment has been minimized.

Contributor

lesteve commented May 31, 2018

This change seems fine to me. There are some failures that seem genuine though (not sure why).

@codecov-io

This comment has been minimized.

codecov-io commented May 31, 2018

Codecov Report

Merging #384 into master will increase coverage by 0.79%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
+ Coverage   92.07%   92.87%   +0.79%     
==========================================
  Files          27       27              
  Lines        1842     1908      +66     
==========================================
+ Hits         1696     1772      +76     
+ Misses        146      136      -10
Impacted Files Coverage Δ
sphinx_gallery/gen_rst.py 95.96% <ø> (+0.28%) ⬆️
sphinx_gallery/tests/test_gen_rst.py 98.61% <100%> (ø) ⬆️
sphinx_gallery/docs_resolv.py 70.4% <0%> (-0.06%) ⬇️
sphinx_gallery/tests/test_docs_resolv.py 100% <0%> (ø) ⬆️
sphinx_gallery/tests/test_gen_gallery.py 100% <0%> (ø) ⬆️
sphinx_gallery/tests/test_binder.py 100% <0%> (ø) ⬆️
sphinx_gallery/gen_gallery.py 86.74% <0%> (+0.94%) ⬆️
sphinx_gallery/binder.py 95.95% <0%> (+15.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed9e6b...96c6125. Read the comment docs.

@larsoner

This comment has been minimized.

Contributor

larsoner commented May 31, 2018

Better code coverage than I thought meant there was a test to update. CIs are happy now.

@lesteve

This comment has been minimized.

Contributor

lesteve commented May 31, 2018

Merging, thanks!

@lesteve lesteve merged commit 4dd2df0 into sphinx-gallery:master May 31, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 92.07%)
Details
codecov/project 92.87% (+0.79%) compared to 2ed9e6b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@larsoner larsoner deleted the larsoner:nomarkup branch May 31, 2018

@lesteve

This comment has been minimized.

Contributor

lesteve commented May 31, 2018

Better code coverage than I thought meant there was a test to update.

Always better this way than the other I guess ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment