New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Add SphinxAppWrapper class in test_gen_gallery.py #386

Merged
merged 1 commit into from Jun 4, 2018

Conversation

Projects
None yet
4 participants
@lesteve
Contributor

lesteve commented Jun 4, 2018

It allows to initializes the Sphinx app only after the example files have been
tweaked.

In particular this allows to add the tests that were left out of #379 as mentioned in #379 (comment).

Add SphinxAppWrapper class in test_gen_gallery.py.
It allows to initializes the Sphinx app only after the example files have been
tweaked.

This allows to add the tests that were left out of #379.

@lesteve lesteve force-pushed the lesteve:improve-test-gen-gallery branch from f0941e9 to 76e82ef Jun 4, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Jun 4, 2018

Codecov Report

Merging #386 into master will increase coverage by 0.38%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
+ Coverage   92.94%   93.32%   +0.38%     
==========================================
  Files          27       27              
  Lines        1914     1949      +35     
==========================================
+ Hits         1779     1819      +40     
+ Misses        135      130       -5
Impacted Files Coverage Δ
sphinx_gallery/tests/test_gen_gallery.py 100% <100%> (ø) ⬆️
sphinx_gallery/gen_gallery.py 89.94% <0%> (+2.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d789067...76e82ef. Read the comment docs.

@larsoner

LGTM +1 for merge once the CIs are happy

@Titan-C

This comment has been minimized.

Member

Titan-C commented Jun 4, 2018

This looks really nice. Thank you @lesteve +1

@lesteve

This comment has been minimized.

Contributor

lesteve commented Jun 4, 2018

CIs are green, let's merge this one!

@lesteve lesteve merged commit 77be493 into sphinx-gallery:master Jun 4, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 92.94%)
Details
codecov/project 93.32% (+0.38%) compared to d789067
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lesteve lesteve deleted the lesteve:improve-test-gen-gallery branch Jun 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment