New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Rename sphinxgallery package to sphinx_gallery #66

Merged
merged 1 commit into from Oct 28, 2015

Conversation

Projects
None yet
4 participants
@lesteve
Contributor

lesteve commented Oct 27, 2015

for consistency with the sphinx-gallery project name.

Fix #47.

Rename sphinxgallery package to sphinx_gallery
for consistency with the sphinx-gallery project name.

@lesteve lesteve force-pushed the lesteve:rename-sphinx-gallery-with-an-underscore branch from 8befab3 to abf4a8d Oct 27, 2015

@Titan-C

This comment has been minimized.

Member

Titan-C commented Oct 27, 2015

Now I'm wondering if we should have a change log file. I'm specially concerned as this next release will break some backwards compatibility. We change the configuration variables from examples_dir to examples_dirs, now is plural and we are also renaming the module.

@GaelVaroquaux

This comment has been minimized.

Contributor

GaelVaroquaux commented Oct 27, 2015

Now I'm wondering if we should have a change log file.

That's a good idea. Do a CHANGES.txt file and 'include' it somewhere in
the docs. You can see how joblib does it for instance.

@lesteve lesteve referenced this pull request Oct 28, 2015

Closed

Add whats_new/CHANGES file #67

@lesteve

This comment has been minimized.

Contributor

lesteve commented Oct 28, 2015

Do a CHANGES.txt file and 'include' it somewhere in the docs

Created #67 about adding a whats_new file.

@lesteve

This comment has been minimized.

Contributor

lesteve commented Oct 28, 2015

If nobody can see any issues with the sphinxgallery -> sphinx_gallery renaming, I'll merge this in a couple of hours.

@agramfort

This comment has been minimized.

Contributor

agramfort commented Oct 28, 2015

besides the fact that MNE is released with the old import I am fine :)

On Wed, Oct 28, 2015 at 11:25 AM, Loïc Estève notifications@github.com
wrote:

If nobody can see any issues with the sphinxgallery -> sphinx_gallery
renaming, I'll merge this in a couple of hours.


Reply to this email directly or view it on GitHub
#66 (comment)
.

@lesteve

This comment has been minimized.

Contributor

lesteve commented Oct 28, 2015

besides the fact that MNE is released with the old import I am fine :)

Don't you ship a copy of sphinx-gallery within MNE-python ?

@agramfort

This comment has been minimized.

Contributor

agramfort commented Oct 28, 2015

@lesteve

This comment has been minimized.

Contributor

lesteve commented Oct 28, 2015

nope due to avoid debian packaging issues. But don't worry we'll backport

OK thanks.

Nobody complained loudly so I am merging this one.

lesteve added a commit that referenced this pull request Oct 28, 2015

Merge pull request #66 from lesteve/rename-sphinx-gallery-with-an-und…
…erscore

[MRG] Rename sphinxgallery package to sphinx_gallery

@lesteve lesteve merged commit a7aaff0 into sphinx-gallery:master Oct 28, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lesteve lesteve deleted the lesteve:rename-sphinx-gallery-with-an-underscore branch Oct 28, 2015

@GaelVaroquaux

This comment has been minimized.

Contributor

GaelVaroquaux commented Oct 28, 2015

@lesteve

This comment has been minimized.

Contributor

lesteve commented Oct 28, 2015

There's a logical fallacy here: aside from @agramfort, your end-users are not aware of this choice, so they cannot complain :)

Let's keep the philosopy/formal logic discussions for lunch, shall we ?

More seriously we can probably put together a backward-compatible mechanism if it turns out to be a real problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment