Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impose sphinx-tabs<=3.5.0 #115

Merged
merged 1 commit into from Jun 28, 2022

Conversation

jorgepiloto
Copy link
Contributor

@jorgepiloto jorgepiloto commented Jun 27, 2022

Resolves #114 by imposing:

-sphinx-tabs<3.4.0,>=1.2.1
+sphinx-tabs<3.5.0,>=1.2.1

Main advantage of sphinx-tabs==3.4.0 is that its supports Sphinx>=5.0.

@jorgepiloto
Copy link
Contributor Author

jorgepiloto commented Jun 27, 2022

Solves ansys/pyansys-dev-guide#135 too once a patch release of sphinx-toolbox is done.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2568343240

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.682%

Totals Coverage Status
Change from base Build 2473080707: 0.0%
Covered Lines: 4034
Relevant Lines: 4400

💛 - Coveralls

Copy link
Member

@domdfcoding domdfcoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. sphinx-tabs is capped because sphinx-toolbox customises it slightly, and in the past that broke when they released a new version. I will add a comment so it's clear in the future.

@domdfcoding domdfcoding merged commit 907d575 into sphinx-toolbox:master Jun 28, 2022
@domdfcoding domdfcoding added this to the v3.1.2 milestone Jun 28, 2022
@jorgepiloto
Copy link
Contributor Author

Thanks for the explanation and the review, @domdfcoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support sphinx-tabs <= 3.4.0
3 participants