Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ingestion of transaction/correlation ids #377

Closed
lukekim opened this issue Oct 29, 2021 · 3 comments · Fixed by #407
Closed

Support ingestion of transaction/correlation ids #377

lukekim opened this issue Oct 29, 2021 · 3 comments · Fixed by #407
Assignees
Labels
kind/enhancement New feature or request

Comments

@lukekim
Copy link
Contributor

lukekim commented Oct 29, 2021

Enable the engine to ingest transaction or correlation ids, like order_id or trace_id.

To ingest unique ids today, they would need to be set as categories, which is not scalable beyond a few ids. The initial version of this feature would simply enable them to be ingested, and round-tripped through the data APIs. In the second iteration, they would be available for reference in reward functions, and the third the potential to automatically correlate and flatten multiple rows of data on the id.

Proposed manifest

dataspaces:
  - from: coinbase
    name: btcusd
    identifiers:
      - transaction_id
      - tick_id
    measurements:
      ...

alternative proposal:

dataspaces:
  - from: coinbase
    name: btcusd
    transactions:
      identifiers:
        - transaction_id
        - tick_id
    measurements:
      ...

alternative proposal:

dataspaces:
  - from: coinbase
    name: btcusd
    transactions:
      identifiers:
        - transaction_id
        - tick_id
      operator: and | or
    measurements:
      ...

alternative proposal:

dataspaces:
  - from: coinbase
    name: btcusd
    correlation_ids:
      - transaction_id
      - tick_id
    measurements:
      ...
@lukekim lukekim added the kind/enhancement New feature or request label Oct 29, 2021
@lukekim lukekim added this to the v0.4-alpha (11/16) milestone Oct 31, 2021
@phillipleblanc phillipleblanc changed the title Support transaction/correlation ids Support ingestion of transaction/correlation ids Nov 2, 2021
@lukekim lukekim self-assigned this Nov 2, 2021
@phillipleblanc
Copy link
Contributor

Enable the engine to ingest transaction or correlation ids, like order_id or trace_id.

Are these useful as inputs to the model? Or only as inputs to the reward function/correlating multiple rows.

To ingest unique ids today, they would need to be set as categories, which is not scalable beyond a few ids. The initial version of this feature would simply enable them to be ingested, and round-tripped through the data APIs. In the second iteration, they would be available for reference in reward functions, and the third the potential to automatically correlate and flatten multiple rows of data on the id.

For the initial version, are we sending them through to the AI Engine - or just storing them on the Go side?

Proposed manifest

dataspaces:
  - from: coinbase
    name: btcusd
    identifiers:
      - transaction_id
      - tick_id
    measurements:
      ...

I like this version 👍

@lukekim
Copy link
Contributor Author

lukekim commented Nov 3, 2021

@phillipleblanc the later.

Iteration 1. Just storing them, and round-tripping back through API/Dashboard for viewing.

Iteration 2. Maybe as input to reward function, not sure how valuable that would be yet.

Iteration 3. Multiple row correlation/merging.

@Corentin-pro
Copy link
Contributor

Corentin-pro commented Nov 3, 2021

I like the 2 first manifest proposals.

I do not think categories the same way as they add new column dimension to the dataset and they have a fixed set of possible values that can be common between records/entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants