Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support kubevirt vm static ip #2360

Merged
merged 3 commits into from
Oct 25, 2023
Merged

support kubevirt vm static ip #2360

merged 3 commits into from
Oct 25, 2023

Conversation

Icarus9913
Copy link
Collaborator

@Icarus9913 Icarus9913 commented Sep 25, 2023 •
edited

  1. support kubevirt vm pod static IP
  2. support kubevirt live migration (auto turn off live migration new pod IP conflict detection in SpiderCoordinator)

Signed-off-by: Icarus9913 icaruswu66@qq.com

What this PR does / why we need it:
new featue

Which issue(s) this PR fixes:
close #2163
close #2442

@Icarus9913 Icarus9913 added the pr/not-ready not ready for merging label Sep 25, 2023
@Icarus9913 Icarus9913 force-pushed the feat/wk/kubevirt-static-ip branch 2 times, most recently from 449c003 to 5f96ff9 Compare September 25, 2023 10:12
@Icarus9913
Copy link
Collaborator Author

migration, multus...

@Icarus9913 Icarus9913 force-pushed the feat/wk/kubevirt-static-ip branch 6 times, most recently from 136aa32 to 7d8ff74 Compare September 28, 2023 09:20
@Icarus9913 Icarus9913 added the release/feature-new release note for new feature label Sep 28, 2023
@codecov
Copy link

codecov bot commented Oct 7, 2023 •
edited

Codecov Report

Merging #2360 (d0d2c8c) into main (3e357ab) will decrease coverage by 0.18%.
Report is 2 commits behind head on main.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2360      +/-   ##
==========================================
- Coverage   80.97%   80.79%   -0.18%     
==========================================
  Files          49       49              
  Lines        5251     5280      +29     
==========================================
+ Hits         4252     4266      +14     
- Misses        842      857      +15     
  Partials      157      157
Flag Coverage Δ
unittests 80.79% <62.50%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/ippoolmanager/config.go 100.00% <ø> (ø)
pkg/ippoolmanager/ippool_manager.go 85.06% <100.00%> (+0.44%) ⬆️
pkg/workloadendpointmanager/utils.go 100.00% <100.00%> (ø)
...orkloadendpointmanager/workloadendpoint_manager.go 97.19% <80.00%> (-2.81%) ⬇️
pkg/podmanager/utils.go 58.62% <0.00%> (-41.38%) ⬇️

@Icarus9913 Icarus9913 added pr/ready-review This pull is ready for review and removed pr/not-ready not ready for merging labels Oct 7, 2023
@weizhoublue
Copy link
Collaborator

1 需要 E2E 冒烟闭环下
2 doc

@Icarus9913 Icarus9913 closed this Oct 9, 2023
@Icarus9913 Icarus9913 reopened this Oct 9, 2023
@Icarus9913 Icarus9913 force-pushed the feat/wk/kubevirt-static-ip branch 3 times, most recently from 92b77f2 to c01284b Compare October 10, 2023 01:57
@Icarus9913 Icarus9913 force-pushed the feat/wk/kubevirt-static-ip branch 2 times, most recently from 74bb245 to 2750b7c Compare October 17, 2023 08:41
@Icarus9913
support kubevirt vm static ip
7a76a2b 
Signed-off-by: Icarus9913 <icaruswu66@qq.com>
weizhoublue
weizhoublue reviewed Oct 19, 2023
View reviewed changes
test/Makefile.defs Outdated Show resolved Hide resolved
@Icarus9913 Icarus9913 force-pushed the feat/wk/kubevirt-static-ip branch 2 times, most recently from 9f271b7 to 2517944 Compare October 19, 2023 12:55
@Icarus9913 Icarus9913 force-pushed the feat/wk/kubevirt-static-ip branch 4 times, most recently from 20459b9 to 1b4ec93 Compare October 20, 2023 09:13
@Icarus9913
add kubevirt e2e
4c218f1 
Signed-off-by: Icarus9913 <icaruswu66@qq.com>
@weizhoublue weizhoublue merged commit e8413ee into spidernet-io:main Oct 25, 2023
34 of 35 checks passed
@ty-dc ty-dc mentioned this pull request Oct 25, 2023
Closed
@Icarus9913 Icarus9913 deleted the feat/wk/kubevirt-static-ip branch December 14, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weizhoublue weizhoublue weizhoublue left review comments

@windsonsea windsonsea Awaiting requested review from windsonsea windsonsea is a code owner

@Michelle951 Michelle951 Awaiting requested review from Michelle951

@Jeanine-tw Jeanine-tw Awaiting requested review from Jeanine-tw

@ty-dc ty-dc Awaiting requested review from ty-dc ty-dc is a code owner

@bzsuni bzsuni Awaiting requested review from bzsuni bzsuni is a code owner

Assignees
No one assigned
Labels
pr/ready-review This pull is ready for review release/feature-new release note for new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StatefulSet pod lost static IP feature: fixed ip for kubevirt
2 participants
@Icarus9913 @weizhoublue