This repository has been archived by the owner on Oct 16, 2020. It is now read-only.
Issue25 #26
Merged
Issue25 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What: Source ICFG: Missing arbitrary edges b/w successive lines in a method Why: this was happening because edges were being created between nodes that were not part of the graph. This would happen in case the node with a certain label already existed and for we tried to create the node with the same label, again; and since a node with the label already existed the new node would be ignored by the graph. But, the edge was getting created with the new node, not the original node. Fix: This fix ensures that if a node with a given lable already exsits, then a new node is not created, and the existing/orignal node is used instead, esp. for creating new edges.
What: This change avoids any self loops in the source ICFG, where self loops are edges with the same source and target. Why: - This can happen if a source code statement (in Java) is translated to two or more successive Jimple (or other IR) statements. Thereby, resulting in the edges between the Jimple statements, which belong to the same source statement, to get translated to an edge in the soruce ICFG where the source and traget nodes are the same. - Also having such statements is not particularly useful in the source level ICFG Fix: simply not adding an edge between two node if they are the same.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.