Increase resilience to very low/high TTLs #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Lowered TTL check related timers to 5 seconds. - Capped preparation/activation lifetimes to 30 days and 7 days, respectively Signed-off-by: Andrew Harding <azdagron@gmail.com>
azdagron
requested review from
amartinezfayo,
evan2645,
MarcosDY,
marcosy and
martincapello
as code owners
There was a problem hiding this comment.
Thanks for this @azdagron!
Looks good. I have a small comment.
pkg/agent/manager/config.go
Outdated
| @@ -48,7 +48,7 @@ func New(c *Config) (*manager, error) { | |||
| } | |||
|
|
|||
| if c.RotationInterval == 0 { | |||
| c.RotationInterval = 60 * time.Second | |||
| c.RotationInterval = 5 * time.Second | |||
There was a problem hiding this comment.
maybe we can export svid.defaultInterval and use it here?
pkg/agent/svid/rotator_config.go
Outdated
| @@ -17,7 +17,7 @@ import ( | |||
| "github.com/sirupsen/logrus" | |||
| ) | |||
|
|
|||
| const defaultInterval = 60 * time.Second | |||
| const defaultInterval = 5 * time.Second | |||
There was a problem hiding this comment.
we may export this const to be used in the manager package?
…ence Signed-off-by: Andrew Harding <azdagron@gmail.com>
Signed-off-by: Andrew Harding <azdagron@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When TTLs are very low (i.e. lower than ~2x the internal timers that check for expiration) then the agent or server can miss its chance for renewal. The current timers are set to 30 seconds, which makes it hard to use low TTLs for testing/demo purposes. This PR drops the timers down to 5 seconds.
When CA TTLs are very high, SPIRE server prepares and activates much to early. For example, if the CA TTL is one year, a new one will be prepared at six months and activated with two months remaining. This change caps the preparation/activation time to 30 and 7 days from expiration, respectively.