Remove Noop NodeResolver plugin #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The noop noderesolver dates back to a time before node resolvers were made optional and paired with node attestors. As node resolvers are no longer required, it is an unneccessary plugin and its presence in the codebase and in documentation is a source of confusion. This change rips the noop noderesolver plugin out. Considering the noop plugin has been present in the sample documentation for quite some time, it is possible that existing deployments have it configured. As such, the noop configuration is detected and a warning message logged. Signed-off-by: Andrew Harding <aharding@vmware.com>
azdagron
requested review from
amartinezfayo,
APTy,
evan2645 and
rturner3
as code owners
wwentland
pushed a commit
to wwentland/spire-tutorials
that referenced
this pull request
Oct 27, 2021
The noop NodeResolver has been removed in 1.0.0. See: - spiffe/spire#2189 Signed-off-by: Wolodja Wentland <wolodja.wentland@control-plane.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The noop noderesolver dates back to a time before node resolvers were made optional and paired with node attestors. As node resolvers are no longer required, it is an unneccessary plugin and its presence in the codebase and in documentation is a source of confusion.
This change rips the noop noderesolver plugin out. Considering the noop plugin has been present in the sample documentation for quite some time, it is possible that existing deployments have it configured. As such, the noop configuration is detected and a warning message logged.