fix broken node API x509 validation #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azdagron
requested review from
amartinezfayo,
evan2645,
MarcosDY,
martincapello and
walmav
as code owners
The gRPC server TLS configuration was misconfigured to only request a client certificate, but not perform validation. The implication is that a certificate chained to any root with an expected SPIFFE ID could impersonate a node SVID and obtain workload SVIDs. Signed-off-by: Andrew Harding <azdagron@gmail.com>
azdagron
force-pushed
the
fix-broken-node-x509-validation
branch
from
8e2f039
to
4a95117
Compare
|
Given the severity of this, I think I'd like to see a regression test added somewhere. I've seen this exact bug pop up in half the Golang TLS client-cert projects I've worked on .... |
|
The unit tests ensure the TLS config is correct, but I agree, an explicit test using client TLS connections to the gRPC server would be a stronger assertion. I'll add such a test. |
evan2645
reviewed
Dec 19, 2018
pkg/server/endpoints/node/handler.go
Outdated
| if len(tlsInfo.State.PeerCertificates) == 0 { | ||
| return nil, errors.New("PeerCertificates was empty") | ||
| if len(tlsInfo.State.VerifiedChains) == 0 { | ||
| return nil, errors.New("VerifiedChains was empty") |
There was a problem hiding this comment.
I know this is similar to the previous error, but it would be good to be more descriptive here (and below as well)
Signed-off-by: Andrew Harding <azdagron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gRPC server TLS configuration was misconfigured to only request a
client certificate, but not perform validation. The implication is that
a certificate chained to any root with an expected SPIFFE ID could
impersonate a node SVID and obtain workload SVIDs.