Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Microsoft Office 2007 on Win XP #6

Open
timdiggins opened this Issue Mar 10, 2014 · 2 comments

Comments

Projects
None yet
2 participants

I've discovered that Microsoft Office 2007 on Win XP (at least, one I've seen...) gives a user agent that seems to be identical to IE 7...

So in my fork I've made a test & fix for this (timdiggins/fix_microsoft_links@0bfc37d), though it's likely to make IE7 present the blank page with meta-refrsh (does anyone care). Can create a pull request if you think this is generally useful.

Owner

spilliton commented Mar 11, 2014

Interesting...so many different user agents!

Sounds reasonable, if anyone complains we can make this part configurable. Go ahead and make a PR if you want :)

Actually, I've discovered that it was something was matching IE11 user agent, so I'm now a bit nervous of using this gem at all (have backed out from it). I think I'd rather check for unauthorized and THEN match (and possibly just display a login page at that point). More change, but much safer. Will report back if/when I find out the user agent for IE11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment