Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgraded TensorFlow to 1.5 to fix AVX incompatibility #2618

Merged
merged 3 commits into from Mar 2, 2020

Conversation

jcohenadad
Copy link
Member

@jcohenadad jcohenadad commented Feb 29, 2020

Older CPUs do not support AVX, which is a requirement for TF>1.5. Several users (>5) are not able to use SCT because of that, so this PR downgrades TF to 1.5 until we find another solution (e.g., move to Pytorch).

Also removed requirements-freeze.txt (it was mistakenly added to master branch, but should only be present in release)

Fixes #2562

@jcohenadad jcohenadad added this to the 4.2.3 milestone Feb 29, 2020
@jcohenadad jcohenadad added the installation category: install_sct or pip/setup.py label Feb 29, 2020
Copy link

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me; installation, sct_check_dependencies, and sct_testing all succeed with the correct downgraded TF/Keras versions. I haven't had a chance to try retraining the models, though.

@jcohenadad
Copy link
Member Author

jcohenadad commented Mar 1, 2020

Thanks @bcdarwin! Before merging I'd like to get feedback from at least one user in this situation to make sure it works on their end. Users contacted:

UPDATED 2020-03-02 10:16:36: worked for one of the user above:
http://forum.spinalcordmri.org/t/installation-failed-during-installation-of-keras/349/9?u=jcohenadad

@jcohenadad
Copy link
Member Author

jcohenadad commented Mar 2, 2020

Since this is a big deal, I am also testing all the scripts from the SCT course...

UPDATE 2020-03-02 11:52:15: Everything went fine 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation category: install_sct or pip/setup.py
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Illegal instruction when importing Keras/Tensorflow with CPU not supporting AVX
2 participants