make spin_sdk.http.IncomingHandler optional
#111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building a component intended for composition with other components, it may make sense to target the `spin-imports` world defined in the `src/spin_sdk/wit/spin.wit` file in this repo. However, that currently won't work because `spin_sdk.http` unconditionally imports `spin_sdk.wit.exports`, which won't exist when targeting `spin-imports`. The solution is to catch the `ImportError` if importing the `exports` submodule (or its `IncomingHandler` class) fails and just skip defining `spin_sdk.http.IncomingHandler` when that happens. Fixes #110 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
karthik2804
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a component intended for composition with other components, it may make sense to target the
spin-importsworld defined in thesrc/spin_sdk/wit/spin.witfile in this repo. However, that currently won't work becausespin_sdk.httpunconditionally importsspin_sdk.wit.exports, which won't exist when targetingspin-imports.The solution is to catch the
ImportErrorif importing theexportssubmodule (or itsIncomingHandlerclass) fails and just skip definingspin_sdk.http.IncomingHandlerwhen that happens.Fixes #110